ConeyLiu commented on pull request #29770: URL: https://github.com/apache/spark/pull/29770#issuecomment-693410322
> But Main.class's childArgs is retrieved from SparkSubmit( 4-tuple return value of prepareSubmitEnvironment)? Look the code may be more clear. The `main` method receives arguments as well. So the parsed args will be passed into the main method in client mode, and we do not need to append some special arguments. The extra append arguments need to be appended when in cluster mode. > So it's another topic? Which means that the current design of SparkSubmit.scala and ExternalClusterManager is not so elegant, user who want to use UserDefinedClusterManager should also modify SparkSubmit besides the user-defined-scheduler part? Yes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
