zero323 commented on a change in pull request #29591: URL: https://github.com/apache/spark/pull/29591#discussion_r489509397
########## File path: python/pyspark/sql/pandas/_typing/protocols/series.pyi ########## @@ -0,0 +1,253 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# This Protocol resuses core Pandas annotation. +# Overall pipeline looks as follows +# - Stubgen pandas.core.series +# - Add Protocol as a base class +# - Replace imports with Any + +import numpy as np # type: ignore[import] +from typing import Any, Callable, Hashable, IO, Optional +from typing_extensions import Protocol + +groupby_generic = Any + +class SeriesLike(Protocol): Review comment: One argument for keeping this as-is, is that it is primarily an internal type checking feature. It is not exposed in a way that can be used by the final user (though I thought about it in the past). Thought it might be an argument against keeping it in the first place. One more option is to extract both Pandas annotations from source just for the use in CI pipeline, until typed version is released. This will ensure consistency on our side. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
