Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5359#issuecomment-89868557
LGTM. Merged into master. @Lewuathe There is a minor issue with your test.
It doesn't actually test normL1 and normL2 but just the size of the output. We
can create a RDD like
~~~
rdd = sc.parallelize(xrange(10)).map(lambda x: Vectors.dense(x))
...
assert normL1 and normL2
~~~
Could you submit another PR and update the test? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
