tomvanbussel commented on a change in pull request #29785:
URL: https://github.com/apache/spark/pull/29785#discussion_r490306476
##########
File path:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
##########
@@ -217,18 +211,20 @@ public boolean hasSpaceForAnotherRecord() {
}
public void expandPointerArray(LongArray newArray) {
- if (newArray.size() < array.size()) {
- // checkstyle.off: RegexpSinglelineJava
- throw new SparkOutOfMemoryError("Not enough memory to grow pointer
array");
- // checkstyle.on: RegexpSinglelineJava
+ if (array != null) {
+ if (newArray.size() < array.size()) {
+ // checkstyle.off: RegexpSinglelineJava
Review comment:
No clue. The lines with the comments are newer than the line between
them, so I'm sure they're good for something...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
