Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/3247#discussion_r27783773
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -26,9 +26,12 @@ trait FunctionRegistry {
def registerFunction(name: String, builder: FunctionBuilder): Unit
- def lookupFunction(name: String, children: Seq[Expression]): Expression
-
def caseSensitive: Boolean
+
+ def lookupFunction(
+ name: String,
+ children: Seq[Expression],
+ distinct: Boolean = false): Expression
--- End diff --
In Spark SQL, we put everything about the expression, as its constructor
argument list, but Hive requires some additional object to keep the expression
info, and both of them will be initialized/used within the executors. We need
to throw exception if it's not an UDAF once `distinct` was set to true.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
