cloud-fan commented on a change in pull request #29585:
URL: https://github.com/apache/spark/pull/29585#discussion_r490369970
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
##########
@@ -342,11 +342,12 @@ object RewriteCorrelatedScalarSubquery extends
Rule[LogicalPlan] {
*/
private def extractCorrelatedScalarSubqueries[E <: Expression](
expression: E,
- subqueries: ArrayBuffer[ScalarSubquery]): E = {
+ subqueries: ArrayBuffer[(ScalarSubquery, ExprId)]): E = {
val newExpression = expression transform {
case s: ScalarSubquery if s.children.nonEmpty =>
- subqueries += s
- s.plan.output.head
+ val newExprId = NamedExpression.newExprId
+ subqueries += s -> newExprId
+ s.plan.output.head.withExprId(newExprId)
Review comment:
we need more comments to explain what's going on here: we will rewrite
the subqueries later and reference their results here by a new attribute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
