dongjoon-hyun commented on a change in pull request #29771:
URL: https://github.com/apache/spark/pull/29771#discussion_r490467256
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2555,6 +2555,18 @@ class DataFrameSuite extends QueryTest
val df = Seq(0.0 -> -0.0).toDF("pos", "neg")
checkAnswer(df.select($"pos" > $"neg"), Row(false))
}
+
+ test("SPARK-32635: Replace references with foldables coming only from the
node's children") {
Review comment:
Although this end-to-end test is also useful, we had better have a
narrow-downed test coverage at `FoldablePropagationSuite` in `catalyst` module.
Could you add one please? If then, we can easily detect regression in
`catalyst` module test instead of a full `sql` testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
