HeartSaVioR commented on a change in pull request #29767:
URL: https://github.com/apache/spark/pull/29767#discussion_r490662661
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
##########
@@ -169,26 +171,32 @@ class InMemoryTable(
new WriteBuilder with SupportsTruncate with SupportsOverwrite with
SupportsDynamicOverwrite {
private var writer: BatchWrite = Append
+ private var streamingWriter: StreamingWrite = StreamingAppend
override def truncate(): WriteBuilder = {
assert(writer == Append)
writer = TruncateAndAppend
+ streamingWriter = StreamingTruncateAndAppend
this
}
override def overwrite(filters: Array[Filter]): WriteBuilder = {
assert(writer == Append)
writer = new Overwrite(filters)
+ // streaming writer doesn't have equivalent semantic
Review comment:
Yes, at least for now. If we would like to be sure, we may be able to
assign dummy one and throw error on calling `buildForStreaming()`. Probably
it'd be much clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
