HyukjinKwon commented on a change in pull request #29794:
URL: https://github.com/apache/spark/pull/29794#discussion_r490670254
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CanonicalizeSuite.scala
##########
@@ -95,4 +96,19 @@ class CanonicalizeSuite extends SparkFunSuite {
val castWithTimeZoneId = Cast(literal, LongType,
Some(TimeZone.getDefault.getID))
assert(castWithTimeZoneId.semanticEquals(cast))
}
+
+ test("SPARK-32927: Bitwise operations are commutative") {
+ Seq(
Review comment:
nit:
```scala
Seq(BitwiseOr(_, _), BitwiseAnd(_, _), BitwiseXor(_, _)).foreach { f =>
val e1 = f('a, f('b, 'c))
val e2 = f(f('a, 'b), 'c)
val e3 = f('a, f('b, 'a))
assert(e1.canonicalized == e2.canonicalized)
assert(e1.canonicalized != e3.canonicalized)
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
