dongjoon-hyun commented on a change in pull request #29789:
URL: https://github.com/apache/spark/pull/29789#discussion_r490677550
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -400,7 +400,10 @@ private[spark] class Executor(
// Report executor runtime and JVM gc time
Option(task).foreach(t => {
t.metrics.setExecutorRunTime(TimeUnit.NANOSECONDS.toMillis(
- System.nanoTime() - taskStartTimeNs))
+ // SPARK-32898: it's possible that a task be killed before it reaches
+ // "taskStartTimeNs = System.nanoTime()". In this case, the
executorRunTime
Review comment:
`before it reaches "taskStartTimeNs = System.nanoTime()"` might be a
little misleading because this looks like equality. If we want to pointing
[line
470](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/executor/Executor.scala#L470),
can we use a different wording? For example, something like, `it's possible
that a task is killed when taskStartTimeNs has the initial value(=0) still`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
