maropu commented on a change in pull request #29780:
URL: https://github.com/apache/spark/pull/29780#discussion_r490737264
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -129,10 +129,10 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan]
{
Coalesce(children.map(normalize))
case _ if expr.dataType.isInstanceOf[StructType] =>
- val fields = expr.dataType.asInstanceOf[StructType].fields.indices.map {
i =>
- normalize(GetStructField(expr, i))
+ val fields =
expr.dataType.asInstanceOf[StructType].fieldNames.zipWithIndex.map {
+ case (name, i) => Seq(Literal(name), normalize(GetStructField(expr,
i)))
}
- val struct = CreateStruct(fields)
+ val struct = CreateNamedStruct(fields.flatten.toSeq)
Review comment:
Yeah, you're right and this is not an user-facing bug. When writing code
to check paln integrity for `SparkPlan`s, I found this issue; canonicalized
attributes between final/partial `HaashAggregate`s were not equal incorrectly
because of this issue (schema mismatch).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
