Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/5344#issuecomment-89944441
@mengxr Thanks for review.
I've tested with edge cases and the no exception is found.
```
val mat = Matrices.rand(20, 30, new Random())
println(mat.toString(-1, -5))
println(mat.toString(0, 0))
println(mat.toString(Int.MaxValue, Int.MaxValue))
println(mat.toString(Int.MinValue, Int.MinValue))
println(mat.toString(20, 100))
```
Do you think we need to add some UT?
And Iâd prefer to keep the behavior consistent with breeze implementation
for now. Any suggestion is welcome. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
