Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5261#issuecomment-90008723
@raschild ... hm I would have thought something like `[MINOR] fix assembly
dir location in load-spark-env-sh` is more descriptive. Marcelo still has an
outstanding question for you about `BASH_SOURCE`. What do you think? sounds
like it should either have a comment or change.
I'm still a little confused about which branch this applies to. Yes, I see
you're applying this to `master`, fine. However in 1.3, the two lines you
change don't reference `SPARK_HOME`. I assume the net change in previous
branches is just to set `FWDIR` differently?
I'd like to get this resolved one way or the other.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
