cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-695164039
> I roughly checked the code and I think you need to brush up more by referring the other code and the style doc. Could you? The proposed idea itself looks good and I think its useful. After much discussion and evolution of this PR from valuable reviewer feedback, it was @maropu's turn. @maropu's superpower involves relentless dedication to consistency throughout files and overall consideration to how they're structured. While resolving provided feedback, file names would change,, unit tests would be consolidated, separated, and then consolidated again, public facing documentation would be reconsidered and simplified for best readability, and not a single out-of-band whitespace would survive. @maropu's contributions towards this code review resulted in simplification, clarification, robustness, and a shiny polish of quality from start to finish. At one point he rewrote part of my code according to how he felt it should look and then pushed into my fork, asking me to approve those changes! It was quite humorous for me from the standpoint of thinking about engineers I've worked with in the past would very possibly destroy their keyboard or monitor , hahaha. The bigger picture here, of course, is understanding and appreciating the diversity in thought and perspective @maropu offers during the review experience. Thank you, @maropu ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
