AngersZhuuuu commented on a change in pull request #29692:
URL: https://github.com/apache/spark/pull/29692#discussion_r491639826
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -262,13 +354,24 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends
Rule[SparkPlan] {
val shuffleStages = collectShuffleStages(plan)
- if (shuffleStages.length == 2) {
+ if (shuffleStages.length >= 1) {
Review comment:
> Does this mean we will also handle multi-table join (e.g. three-table
join) ?
Since broadcast nested loop join only can have one side shuffle exchange,
but sort merge join with two
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
