xuanyuanking commented on a change in pull request #29756:
URL: https://github.com/apache/spark/pull/29756#discussion_r491893444
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -39,7 +39,7 @@ import org.apache.spark.sql.catalyst.expressions.{Expression,
ExpressionInfo, Im
import org.apache.spark.sql.catalyst.parser.{CatalystSqlParser,
ParserInterface}
import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan,
SubqueryAlias, View}
import org.apache.spark.sql.catalyst.util.StringUtils
-import org.apache.spark.sql.connector.catalog.CatalogManager
+import org.apache.spark.sql.connector.catalog.{CatalogManager, Identifier}
Review comment:
Delete in 9004fba.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -260,19 +264,47 @@ class FindDataSourceTable(sparkSession: SparkSession)
extends Rule[LogicalPlan]
})
}
+ private def getStreamingRelation(
+ table: CatalogTable,
+ extraOptions: CaseInsensitiveStringMap): StreamingRelation = {
+ val dsOptions = DataSourceUtils.generateDatasourceOptions(extraOptions,
table)
+ val dataSource = DataSource(
+ sparkSession,
+ className = table.provider.get,
+ userSpecifiedSchema = Some(table.schema),
+ options = dsOptions)
+ StreamingRelation(dataSource)
+ }
+
+
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
- case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta,
options), _, _, _, _)
+ case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, options,
false), _, _, _, _)
if DDLUtils.isDatasourceTable(tableMeta) =>
i.copy(table = readDataSourceTable(tableMeta, options))
- case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, _), _,
_, _, _) =>
+ case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, _, _),
_, _, _, _) =>
Review comment:
Yes, done in 9004fba.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
