viirya edited a comment on pull request #29828: URL: https://github.com/apache/spark/pull/29828#issuecomment-696379483
> I believe you didn't add the rule to the Optimizer, only to the one in UT. > Also what happens if the input string is not a valid JSON? Oops, forgot to do it. Thanks. That's good point. <del>So I think this is currently limited to PermissiveMode only.</del> Even only for PermissiveMode, the optimization seems still changing the evaluation. Seems this is only valid for from_json + to_json. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
