Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4142#issuecomment-90245556
I'm not saying the whole method needs refactoring, I'm saying the whole
file needs refactoring. Putting that block - which, semantically, does really
belong in that method - in a separate method won't achieve anything to clean
things up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
