LuciferYang commented on a change in pull request #29824:
URL: https://github.com/apache/spark/pull/29824#discussion_r492167537
##########
File path: resource-managers/yarn/pom.xml
##########
@@ -88,6 +88,13 @@
<artifactId>hadoop-client</artifactId>
</dependency>
+ <dependency>
Review comment:
I'm not sure if we should use `jakarta.servlet-api` instead of
`javax.servlet-api` directly
##########
File path: resource-managers/yarn/pom.xml
##########
@@ -88,6 +88,13 @@
<artifactId>hadoop-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.servlet</groupId>
+ <artifactId>jakarta.servlet-api</artifactId>
+ <version>4.0.3</version>
+ <scope>test</scope>
+ </dependency>
+
Review comment:
cc @srowen I found we add
`org.glassfish.jersey.test-framework.providers` dependency after
https://github.com/apache/spark/pull/25455/files
But I'm not sure should we use `jakarta.servlet-api` as a compile dependency
instead of `javax.servlet-api` directly
##########
File path: resource-managers/yarn/pom.xml
##########
@@ -88,6 +88,13 @@
<artifactId>hadoop-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.servlet</groupId>
+ <artifactId>jakarta.servlet-api</artifactId>
+ <version>4.0.3</version>
+ <scope>test</scope>
+ </dependency>
+
Review comment:
cc @srowen I found we add
`org.glassfish.jersey.test-framework.providers` dependency after #25455
But I'm not sure should we use `jakarta.servlet-api` as a compile dependency
instead of `javax.servlet-api` directly
##########
File path: resource-managers/yarn/pom.xml
##########
@@ -88,6 +88,13 @@
<artifactId>hadoop-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.servlet</groupId>
+ <artifactId>jakarta.servlet-api</artifactId>
+ <version>4.0.3</version>
+ <scope>test</scope>
+ </dependency>
+
Review comment:
cc @srowen I found that we add
`org.glassfish.jersey.test-framework.providers` dependency after #25455 and
brings the test dependence `jakarta.servlet-api` , It has different version
from `javax.servlet-api`.
But I'm not sure should we use `jakarta.servlet-api` as a compile dependency
instead of `javax.servlet-api` directly
##########
File path: resource-managers/yarn/pom.xml
##########
@@ -88,6 +88,13 @@
<artifactId>hadoop-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.servlet</groupId>
+ <artifactId>jakarta.servlet-api</artifactId>
+ <version>4.0.3</version>
+ <scope>test</scope>
+ </dependency>
+
Review comment:
And I'm not sure should we need add this test dependency, but it failed
in my test environment without this dependency
##########
File path: resource-managers/yarn/pom.xml
##########
@@ -88,6 +88,13 @@
<artifactId>hadoop-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.servlet</groupId>
+ <artifactId>jakarta.servlet-api</artifactId>
+ <version>4.0.3</version>
+ <scope>test</scope>
+ </dependency>
+
Review comment:
I've tried it once, but failed. It looks like really need 4.0.x, but
I'll re-check this.
##########
File path: resource-managers/yarn/pom.xml
##########
@@ -88,6 +88,13 @@
<artifactId>hadoop-client</artifactId>
</dependency>
+ <dependency>
+ <groupId>jakarta.servlet</groupId>
+ <artifactId>jakarta.servlet-api</artifactId>
+ <version>4.0.3</version>
+ <scope>test</scope>
+ </dependency>
+
Review comment:
Try to excluding 4.0.x from parent pom.xml and `core/pom.xml` as follow:
then and remove `jakarta.servlet-api` dependency from
`resource-managers/yarn/pom.xml` and rebuild&rerun the test case but still
failed :( ..., It seems that 4.0.x is needed in the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
