sarutak commented on a change in pull request #29827:
URL: https://github.com/apache/spark/pull/29827#discussion_r492480542
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,44 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ webui-tests-with-chrome-maven-
+ - name: Install Java 11
+ uses: actions/setup-java@v1
+ with:
+ java-version: 11
+ - name: Install Chrome and ChromeDriver
+ run: |
+ sudo apt update
+ sudo apt install google-chrome-stable
+ sudo apt install chromium-chromedriver
+ - name: Run WebUI tests with Maven
+ run: |
+ export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
+ export MAVEN_CLI_OPTS="--no-transfer-progress"
+ mkdir -p ~/.m2
+ ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver
\
+ -Dguava.version=25.0-jre -Djava.version=11
-Dtest.default.exclude.tags= -Dtest=none \
Review comment:
The first time those tests are added, they works with `guava 14.0.1`.
I believe #28585 (SPARK-31765) requires upgraded RemoteWebDriver and it
requires `25.0-jre`.
That PR is for a small security issue.
> Do we have a JIRA issue for that test suite failure?
Yes. But we might to need to modify the title.
https://issues.apache.org/jira/browse/SPARK-31996
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,44 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ webui-tests-with-chrome-maven-
+ - name: Install Java 11
+ uses: actions/setup-java@v1
+ with:
+ java-version: 11
+ - name: Install Chrome and ChromeDriver
+ run: |
+ sudo apt update
+ sudo apt install google-chrome-stable
+ sudo apt install chromium-chromedriver
+ - name: Run WebUI tests with Maven
+ run: |
+ export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
+ export MAVEN_CLI_OPTS="--no-transfer-progress"
+ mkdir -p ~/.m2
+ ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver
\
+ -Dguava.version=25.0-jre -Djava.version=11
-Dtest.default.exclude.tags= -Dtest=none \
Review comment:
The first time those tests are added, they works with `guava 14.0.1`.
I believe #28585 (SPARK-31765) requires upgraded RemoteWebDriver and it
requires `25.0-jre`.
That PR is for a small security issue.
> Do we have a JIRA issue for that test suite failure?
Yes. But we might need to modify the title.
https://issues.apache.org/jira/browse/SPARK-31996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
