HeartSaVioR commented on a change in pull request #29830:
URL: https://github.com/apache/spark/pull/29830#discussion_r492680314
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriterV2.scala
##########
@@ -153,6 +153,7 @@ final class DataFrameWriterV2[T] private[sql](table:
String, ds: Dataset[T])
*/
@throws(classOf[NoSuchTableException])
def append(): Unit = {
+ assertNoTempView("append")
val append = loadTable(catalog, identifier) match {
Review comment:
I agree the suggestion is promising, but I'm not sure I understand all
spots I need to modify. I could try to find places where
`InsertIntoStatement(UnresolvedRelation(...))` is resolved, but AppendData and
InsertIntoStatement are not 100% same. In addition, looks like it should be
done for each operation.
I'll take a look at this soon. If you can fix it easily (and you'd like to)
please go ahead and I can learn from your PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
