kiszk commented on pull request #29762: URL: https://github.com/apache/spark/pull/29762#issuecomment-696755160
Thank you. The code and tests alone look good. I have one question about use cases for `hashUnsafeWords`. Regarding `hashUnsafeBytes`. it make sense to return the same hash value against the same byte sequence. How about `hashUnsafeWords()`? In general, a word could have the different byte sequence on little-endian and big-endian (e.g. `78563412` v.s. `12345678`). While I see the caller of `hashUnsafeWords()`, I am not sure what hash value is expected. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
