Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5376#issuecomment-90304410
So I proposed this and a few other similar changes a while ago, and the
feedback was that it wasn't worth the merge conflicts to save a few opcodes. It
is a little faster to call `.length` for an array even if `.size` is more
consistent with the rest of the collections API, and I'd write `.length` in new
code or change it if I were touching some nearby code anyway. I'd also think we
should make this change in tight loops.
So on that basis, do you know of any case here where performance is
non-trivially improved?
CC @JoshRosen for a gut check on whether it's worth changing it all, anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
