Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5375#discussion_r27845691
  
    --- Diff: 
extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala
 ---
    @@ -81,17 +84,19 @@ object KinesisUtils {
        *                                 the tip of the stream 
(InitialPositionInStream.LATEST).
        * @param storageLevel Storage level to use for storing the received 
objects
        *
    -   * @return JavaReceiverInputDStream[Array[Byte]]
    +   * @return JavaReceiverInputDStream[ Array[Byte] ]
        */
       @Experimental
       def createStream(
    -      jssc: JavaStreamingContext, 
    -      streamName: String, 
    -      endpointUrl: String, 
    +      jssc: JavaStreamingContext,
    --- End diff --
    
    Isn't this changing the API?
    I believe you should make a JIRA along with this PR. It's not trivial. 
    https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to