dongjoon-hyun commented on a change in pull request #29827:
URL: https://github.com/apache/spark/pull/29827#discussion_r492453481
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,50 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: java11-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ java11-maven-
Review comment:
@sarutak . Could you tell us why you share the cache key? This task
seems to save different cache into this key and corrupt the existing Java 11
Maven full build.
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,50 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: java11-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ java11-maven-
Review comment:
Thanks!
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,44 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ webui-tests-with-chrome-maven-
+ - name: Install Java 11
+ uses: actions/setup-java@v1
+ with:
+ java-version: 11
+ - name: Install Chrome and ChromeDriver
+ run: |
+ sudo apt update
+ sudo apt install google-chrome-stable
+ sudo apt install chromium-chromedriver
+ - name: Run WebUI tests with Maven
+ run: |
+ export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
+ export MAVEN_CLI_OPTS="--no-transfer-progress"
+ mkdir -p ~/.m2
+ ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver
\
+ -Dguava.version=25.0-jre -Djava.version=11
-Dtest.default.exclude.tags= -Dtest=none \
Review comment:
@sarutak . Apache Spark 3.1's Guava version is still
`<guava.version>14.0.1</guava.version>`, isn't it?
Why do you pig-back something like this important thing silently?
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,44 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ webui-tests-with-chrome-maven-
+ - name: Install Java 11
+ uses: actions/setup-java@v1
+ with:
+ java-version: 11
+ - name: Install Chrome and ChromeDriver
+ run: |
+ sudo apt update
+ sudo apt install google-chrome-stable
+ sudo apt install chromium-chromedriver
+ - name: Run WebUI tests with Maven
+ run: |
+ export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
+ export MAVEN_CLI_OPTS="--no-transfer-progress"
+ mkdir -p ~/.m2
+ ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver
\
+ -Dguava.version=25.0-jre -Djava.version=11
-Dtest.default.exclude.tags= -Dtest=none \
Review comment:
@sarutak . Apache Spark 3.1's official Guava version is still
`<guava.version>14.0.1</guava.version>`, isn't it?
Why do you pig-back something like this important thing silently?
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,44 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ webui-tests-with-chrome-maven-
+ - name: Install Java 11
+ uses: actions/setup-java@v1
+ with:
+ java-version: 11
+ - name: Install Chrome and ChromeDriver
+ run: |
+ sudo apt update
+ sudo apt install google-chrome-stable
+ sudo apt install chromium-chromedriver
+ - name: Run WebUI tests with Maven
+ run: |
+ export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
+ export MAVEN_CLI_OPTS="--no-transfer-progress"
+ mkdir -p ~/.m2
+ ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver
\
+ -Dguava.version=25.0-jre -Djava.version=11
-Dtest.default.exclude.tags= -Dtest=none \
Review comment:
@sarutak . Apache Spark 3.1's official Guava version is still
`<guava.version>14.0.1</guava.version>`, isn't it?
Why do you piggy-back something like this important thing silently?
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,44 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ webui-tests-with-chrome-maven-
+ - name: Install Java 11
+ uses: actions/setup-java@v1
+ with:
+ java-version: 11
+ - name: Install Chrome and ChromeDriver
+ run: |
+ sudo apt update
+ sudo apt install google-chrome-stable
+ sudo apt install chromium-chromedriver
+ - name: Run WebUI tests with Maven
+ run: |
+ export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
+ export MAVEN_CLI_OPTS="--no-transfer-progress"
+ mkdir -p ~/.m2
+ ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver
\
+ -Dguava.version=25.0-jre -Djava.version=11
-Dtest.default.exclude.tags= -Dtest=none \
Review comment:
@sarutak . Apache Spark 3.1's official Guava version is still
`<guava.version>14.0.1</guava.version>`, isn't it?
Why do you piggy-back something important thing silently?
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,44 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ webui-tests-with-chrome-maven-
+ - name: Install Java 11
+ uses: actions/setup-java@v1
+ with:
+ java-version: 11
+ - name: Install Chrome and ChromeDriver
+ run: |
+ sudo apt update
+ sudo apt install google-chrome-stable
+ sudo apt install chromium-chromedriver
+ - name: Run WebUI tests with Maven
+ run: |
+ export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
+ export MAVEN_CLI_OPTS="--no-transfer-progress"
+ mkdir -p ~/.m2
+ ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver
\
+ -Dguava.version=25.0-jre -Djava.version=11
-Dtest.default.exclude.tags= -Dtest=none \
Review comment:
@sarutak . Apache Spark 3.1's official Guava version is still
`<guava.version>14.0.1</guava.version>`, isn't it?
Why do you piggy-back something important thing silently? :)
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,44 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ webui-tests-with-chrome-maven-
+ - name: Install Java 11
+ uses: actions/setup-java@v1
+ with:
+ java-version: 11
+ - name: Install Chrome and ChromeDriver
+ run: |
+ sudo apt update
+ sudo apt install google-chrome-stable
+ sudo apt install chromium-chromedriver
+ - name: Run WebUI tests with Maven
+ run: |
+ export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
+ export MAVEN_CLI_OPTS="--no-transfer-progress"
+ mkdir -p ~/.m2
+ ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver
\
+ -Dguava.version=25.0-jre -Djava.version=11
-Dtest.default.exclude.tags= -Dtest=none \
Review comment:
If the test suite is broken with the default Apache Spark distribution,
we need to revert the root cause which broke the test suite. IIRC, this test
suite is tested with the default configuration initially.
> Actually, I noticed the current ChromeDriver and RemoteWebDriver can't use
guava 14.0.1
Do we have a JIRA issue for that test suite failure?
##########
File path: .github/workflows/build_and_test.yml
##########
@@ -273,6 +273,44 @@ jobs:
cd docs
jekyll build
+ webui-tests-with-chrome:
+ name: WebUI tests with chrome
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout Spark repository
+ uses: actions/checkout@v2
+ - name: Cache Maven local repository
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2/repository
+ key: webui-tests-with-chrome-maven-${{ hashFiles('**/pom.xml') }}
+ restore-keys: |
+ webui-tests-with-chrome-maven-
+ - name: Install Java 11
+ uses: actions/setup-java@v1
+ with:
+ java-version: 11
+ - name: Install Chrome and ChromeDriver
+ run: |
+ sudo apt update
+ sudo apt install google-chrome-stable
+ sudo apt install chromium-chromedriver
+ - name: Run WebUI tests with Maven
+ run: |
+ export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
+ export MAVEN_CLI_OPTS="--no-transfer-progress"
+ mkdir -p ~/.m2
+ ./build/mvn -Dspark.test.webdriver.chrome.driver=/usr/bin/chromedriver
\
+ -Dguava.version=25.0-jre -Djava.version=11
-Dtest.default.exclude.tags= -Dtest=none \
Review comment:
Thank you for the pointer, @sarutak . BTW, there are many request for
Guava update. I believe we can handle this in the same group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
