cloud-fan commented on a change in pull request #29811:
URL: https://github.com/apache/spark/pull/29811#discussion_r492549883
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -758,8 +758,9 @@ class DataSourceV2SQLSuite
test("Relation: view text") {
val t1 = "testcat.ns1.ns2.tbl"
+ val v1 = "view1"
withTable(t1) {
- withView("view1") { v1: String =>
Review comment:
what was the value of `v1` before?
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/TestV2SessionCatalogBase.scala
##########
@@ -47,10 +47,13 @@ private[connector] trait TestV2SessionCatalogBase[T <:
Table] extends Delegating
tables.get(ident)
} else {
// Table was created through the built-in catalog
- val t = super.loadTable(ident)
- val table = newTable(t.name(), t.schema(), t.partitioning(),
t.properties())
- tables.put(ident, table)
- table
+ super.loadTable(ident) match {
+ case v1Table: V1Table if v1Table.v1Table.tableType ==
CatalogTableType.VIEW => v1Table
Review comment:
or we should at least mention it in the PR description, to explain why
it's needed to fix the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
