cloud-fan commented on a change in pull request #29792:
URL: https://github.com/apache/spark/pull/29792#discussion_r493216123
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparisonSuite.scala
##########
@@ -67,6 +77,23 @@ class UnwrapCastInBinaryComparisonSuite extends PlanTest
with ExpressionEvalHelp
assertEquivalent(castInt(f) <=> v.toInt, f <=> v)
assertEquivalent(castInt(f) <= v.toInt, f === v)
assertEquivalent(castInt(f) < v.toInt, falseIfNotNull(f))
+
+ val d = Float.NegativeInfinity
+ assertEquivalent(castDouble(f2) > d.toDouble, f2 =!= d)
Review comment:
is casting double to float rounding up or rounding down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
