cloud-fan commented on a change in pull request #29756:
URL: https://github.com/apache/spark/pull/29756#discussion_r493466003
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -260,19 +264,47 @@ class FindDataSourceTable(sparkSession: SparkSession)
extends Rule[LogicalPlan]
})
}
+ private def getStreamingRelation(
+ table: CatalogTable,
+ extraOptions: CaseInsensitiveStringMap): StreamingRelation = {
+ val dsOptions = DataSourceUtils.generateDatasourceOptions(extraOptions,
table)
+ val dataSource = DataSource(
+ sparkSession,
+ className = table.provider.get,
+ userSpecifiedSchema = Some(table.schema),
+ options = dsOptions)
+ StreamingRelation(dataSource)
+ }
+
+
override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
- case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta,
options), _, _, _, _)
+ case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, options,
false), _, _, _, _)
if DDLUtils.isDatasourceTable(tableMeta) =>
i.copy(table = readDataSourceTable(tableMeta, options))
- case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, _), _,
_, _, _) =>
+ case i @ InsertIntoStatement(UnresolvedCatalogRelation(tableMeta, _,
false), _, _, _, _) =>
i.copy(table = DDLUtils.readHiveTable(tableMeta))
- case UnresolvedCatalogRelation(tableMeta, options) if
DDLUtils.isDatasourceTable(tableMeta) =>
+ case UnresolvedCatalogRelation(tableMeta, options, false)
+ if DDLUtils.isDatasourceTable(tableMeta) =>
readDataSourceTable(tableMeta, options)
- case UnresolvedCatalogRelation(tableMeta, _) =>
+ case UnresolvedCatalogRelation(tableMeta, _, false) =>
DDLUtils.readHiveTable(tableMeta)
+
+ case UnresolvedCatalogRelation(tableMeta, extraOptions, true) =>
+ getStreamingRelation(tableMeta, extraOptions)
+
+ case s @ StreamingRelationV2(
+ _, _, table, extraOptions, _, _, _,
Some(UnresolvedCatalogRelation(tableMeta, _, true))) =>
+ import
org.apache.spark.sql.execution.datasources.v2.DataSourceV2Implicits._
+ if (table.isInstanceOf[SupportsRead]
+ && table.supportsAny(MICRO_BATCH_READ, CONTINUOUS_READ)) {
+ s.copy(v1Relation = None)
Review comment:
shall we put a resolved v1 relation here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
