Ngone51 commented on a change in pull request #29817:
URL: https://github.com/apache/spark/pull/29817#discussion_r494003110
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -166,17 +171,6 @@ private[spark] class CoarseGrainedExecutorBackend(
if (executor == null) {
exitExecutor(1, "Received LaunchTask command but executor was null")
} else {
- if (decommissioned) {
- val msg = "Asked to launch a task while decommissioned."
- logError(msg)
- driver match {
- case Some(endpoint) =>
- logInfo("Sending DecommissionExecutor to driver.")
- endpoint.send(DecommissionExecutor(executorId,
ExecutorDecommissionInfo(msg)))
- case _ =>
- logError("No registered driver to send Decommission to.")
- }
- }
Review comment:
First, we use `askSync` to send decommission notice to the driver
whenever it needs(see `ExecutorSigPWRReceived`). Second, even if driver
receives the decommission notice successfully, there still could be LaunchTask
request due to the async between LaunchTask and decommission notice. Third,
this part also uses async send, so we still can not ensure the decommission
notice is received by driver successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
