zhengruifeng commented on pull request #29850:
URL: https://github.com/apache/spark/pull/29850#issuecomment-698127269


   Scala 2.13 building fail due to:
   ```
    Error: ] 
/home/runner/work/spark/spark/mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala:137:
 type mismatch;
    found   : (String, Int) => Int
    required: String => ?
   Error: ] 
/home/runner/work/spark/spark/mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala:140:
 type mismatch;
    found   : (String, Int) => Int
    required: String => ?
   ```
   
   I will try to fix it.
   
   
   
   > what is the performance speedup that we get from this optimization? Is it 
significant?
   
   @MLnick  I am preparing a performance test, and will post the result ASAP.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to