srowen commented on pull request #29857:
URL: https://github.com/apache/spark/pull/29857#issuecomment-698479253


   For the random forest test, it's probably reasonably to simply change the 
tol in the last test to 0.75 like the others. I don't know why it should be 
higher.
   
   If you like you can try making the ordering of the Map in this code 
deterministic to see if that does it:
   ```
   val topNodesForGroup: Map[Int, LearningNode] = 
        nodesForGroup.keys.map(treeIdx => treeIdx -> topNodes(treeIdx)).toMap 
   ```
   
   But, I don't even know if the result the test is complaining about is 
'wrong'.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to