holdenk commented on pull request #29854: URL: https://github.com/apache/spark/pull/29854#issuecomment-698693708
So the launcher tests were broken by a new version of mini kube being released, it wasn’t broken by any specific PR (except maybe arguably the original PR adding integration tests). As for the revert, that PR was indeed breaking the test suite and had an incompatible change, I asked for it to be reverted but it turned out that folks have not been running that suite for awhile (a mistake I myself have made), so it there were multiple breaking changes and I decided that since it had been proposed to re-merge code with a broken test suite we would be better served by me focusing on fixing the test suite to unblock everyone. If you think this is not a reasonable course of action please bring it up with the PMC. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
