Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5327#issuecomment-90500773
That's a fair question. I suspect it's not worth changing all these scripts
to handle start/stop/status messages. It does require users to execute
`spark-daemon.sh status [class] [instance]` which is ... OK I guess. Will they
know "instance"? it seems to be 1 in other scripts.
Also, since the new logic depends on finding the PID file already, should
the logic `if [[ $(ps -p "$TARGET_ID" -o args=) =~ $command ]]; then` not just
match the `stop` logic, and look for "java"? That is, does the current check
actually match? the class name is not the command-line command. I might be
missing something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
