srowen commented on a change in pull request #29868:
URL: https://github.com/apache/spark/pull/29868#discussion_r494947145
##########
File path: mllib/src/main/scala/org/apache/spark/ml/feature/FeatureHasher.scala
##########
@@ -91,8 +91,7 @@ class FeatureHasher(@Since("2.3.0") override val uid: String)
extends Transforme
/**
* Numeric columns to treat as categorical features. By default only string
and boolean
* columns are treated as categorical, so this param can be used to
explicitly specify the
- * numerical columns to treat as categorical. Note, the relevant columns
must also be set in
- * `inputCols`.
+ * numerical columns to treat as categorical.
Review comment:
This is still 'required' right? we're not making it an error, but it
won't have any effect if not in inputCols.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
