HyukjinKwon commented on a change in pull request #29862:
URL: https://github.com/apache/spark/pull/29862#discussion_r494200005
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
##########
@@ -93,6 +93,12 @@ object CSVUtils {
value
}
}
+ if (header.sameElements(row)) {
+ header
+ } else {
+ // Ensure that the newly generated and existing headers are not
duplicated.
+ makeSafeHeader(header, caseSensitive, options)
+ }
Review comment:
Can you check how R's `read_csv` works in this case? That patch was
inspired by R's one.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
##########
@@ -93,6 +93,12 @@ object CSVUtils {
value
}
}
+ if (header.sameElements(row)) {
+ header
+ } else {
+ // Ensure that the newly generated and existing headers are not
duplicated.
+ makeSafeHeader(header, caseSensitive, options)
+ }
Review comment:
Can you check how R's `read_csv` works in this case? This behaviour was
inspired by R's one.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
##########
@@ -93,6 +93,12 @@ object CSVUtils {
value
}
}
+ if (header.sameElements(row)) {
+ header
+ } else {
+ // Ensure that the newly generated and existing headers are not
duplicated.
+ makeSafeHeader(header, caseSensitive, options)
+ }
Review comment:
Can we follow this behaviour?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVUtils.scala
##########
@@ -93,6 +93,12 @@ object CSVUtils {
value
}
}
+ if (header.sameElements(row)) {
+ header
+ } else {
+ // Ensure that the newly generated and existing headers are not
duplicated.
+ makeSafeHeader(header, caseSensitive, options)
+ }
Review comment:
I mean the numbering. Can. we create a name like `a1 a3 a4 a2` for `a,
a, a, a, a.2`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
