sunchao commented on a change in pull request #29843:
URL: https://github.com/apache/spark/pull/29843#discussion_r494467897
##########
File path: external/kafka-0-10-sql/pom.xml
##########
@@ -79,6 +79,10 @@
<artifactId>kafka-clients</artifactId>
<version>${kafka.version}</version>
</dependency>
+ <dependency>
+ <groupId>com.google.code.findbugs</groupId>
Review comment:
Thanks. Yes will do after making all tests pass.
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -118,11 +118,15 @@ private[hive] object IsolatedClientLoader extends Logging
{
hadoopVersion: String,
ivyPath: Option[String],
remoteRepos: String): Seq[URL] = {
+ val hadoopJarName = if (hadoopVersion.startsWith("3")) {
Review comment:
Yes I think so. These modules should be available in any production
Hadoop 3.x releases I think. See
https://issues.apache.org/jira/browse/HADOOP-11804, it is fixed in 3.0.0-alpha2.
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
##########
@@ -118,11 +118,15 @@ private[hive] object IsolatedClientLoader extends Logging
{
hadoopVersion: String,
ivyPath: Option[String],
remoteRepos: String): Seq[URL] = {
+ val hadoopJarName = if (hadoopVersion.startsWith("3")) {
Review comment:
Yes I believe so. These modules should be available in any production
Hadoop 3.x releases I think. See
https://issues.apache.org/jira/browse/HADOOP-11804, it is fixed in 3.0.0-alpha2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
