Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/5305#discussion_r27883952
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
---
@@ -127,23 +127,11 @@ private[spark] class YarnClientSchedulerBackend(
assert(client != null && appId != null, "Application has not been
submitted yet!")
val t = new Thread {
override def run() {
- while (!stopping) {
- var state: YarnApplicationState = null
- try {
- val report = client.getApplicationReport(appId)
- state = report.getYarnApplicationState()
- } catch {
- case e: ApplicationNotFoundException =>
- state = YarnApplicationState.KILLED
- }
- if (state == YarnApplicationState.FINISHED ||
- state == YarnApplicationState.KILLED ||
- state == YarnApplicationState.FAILED) {
- logError(s"Yarn application has already exited with state
$state!")
- sc.stop()
- stopping = true
- }
- Thread.sleep(1000L)
+ val (state, _) = client.monitorApplication(appId,
logApplicationReport = false)
+ if (!stopping) {
--- End diff --
stop() can be called from other areas of the code (like
SparkContext.stop()). Now that the loop isn't checking for it we wouldn't
interrupt this thread if that happens and I think we need to handle that case.
See the discussions on https://github.com/apache/spark/pull/3143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
