cloud-fan commented on a change in pull request #29054:
URL: https://github.com/apache/spark/pull/29054#discussion_r495007775
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala
##########
@@ -69,7 +69,14 @@ private[sql] class HiveSessionCatalog(
// Current thread context classloader may not be the one loaded the class.
Need to switch
// context classloader to initialize instance properly.
Utils.withContextClassLoader(clazz.getClassLoader) {
- Try(super.makeFunctionExpression(name, clazz, input)).getOrElse {
+ val t = Try(super.makeFunctionExpression(name, clazz, input))
+ if (t.isSuccess) {
+ t.asInstanceOf[Success[Expression]].get
+ } else {
+ val exception = t.asInstanceOf[Failure[Expression]].exception
+ if (exception.getMessage.contains("Invalid number of arguments for
function")) {
Review comment:
can we use a special exception type instead of relying on error message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
