Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/568#discussion_r12080160
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala ---
@@ -474,13 +474,16 @@ class ALS private (
// Compute the XtX and Xy values for each user by adding products it
rated in each product
// block
for (productBlock <- 0 until numBlocks) {
- for (p <- 0 until blockFactors(productBlock).length) {
+ var i = 0
--- End diff --
This `i` is a little far from the while loop that actually uses it. Maybe
it is better to define it just before `while`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
