GitHub user ilganeli opened a pull request:
https://github.com/apache/spark/pull/5394
[SPARK-6746] Refactor large functions in DAGScheduler to improve readibility
Hi all. The DAG Scheduler had several very large, complex, and unreadable
functions. Specifically,
```handleTaskCompletion```, ```cleanupStateForJobAndIndependentStages```,
and ```submitMissingTasks```. This patch is almost exclusively code movement,
very little code has changed with the exception of handling return logic when
serializing tasks within ```submitMissingTasks```.
I believe the final product is much more readable and makes it much easier
to understand what's going on within the DAGScheduler.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilganeli/spark SPARK-6746
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5394
----
commit 045292774f404f1d07204f995afac512ea3b240d
Author: Ilya Ganelin <[email protected]>
Date: 2015-04-07T16:47:01Z
[SPARK-6746] Refactored submitMissingTasks,
cleanupStateForJobAndIndependentStages, and handleTaskCompletion
commit 1e0d48d41c66da35497c20cf7193df52f714b896
Author: Ilya Ganelin <[email protected]>
Date: 2015-04-07T16:50:16Z
Slightly simplified processShuffleTask
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
