Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r27897916
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -74,10 +84,15 @@ case class Generate(
} else {
outputRows.map(or => joinProjection(joinedRow(row, or)))
}
+ } ++ LazyIterator(() => boundGenerator.terminate()).map { row =>
+ joinedRow(nullOriginalRow, row)
}
}
} else {
- child.execute().mapPartitions(iter => iter.flatMap(row =>
boundGenerator.eval(row)))
+ child.execute().mapPartitions(iter =>
+ iter.flatMap(row => boundGenerator.eval(row)) ++
+ LazyIterator(() => boundGenerator.terminate())
--- End diff --
Yes, I that's OK by called in each partition.
See
https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java#L278
https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java#L192
The `Operator.close()` is called in `MapReduceBase.close`, which mean they
are supposed to run once within each Mapper/Reducer.
And
https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/UDTFOperator.java#L144
https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java#L616
shows the `genericUDTF.close()` is called within the `Operator.close`.
Sorry, please correct me if my understanding is wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
