imback82 commented on a change in pull request #29880:
URL: https://github.com/apache/spark/pull/29880#discussion_r495505316
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -168,7 +168,31 @@ class DataSourceV2SQLSuite
Array("Provider", "foo", ""),
Array(TableCatalog.PROP_OWNER.capitalize, defaultUser, ""),
Array("Table Properties", "[bar=baz]", "")))
+ }
+ test("Describe column is not supported for v2 catalog") {
Review comment:
There doesn't seem to be a test coverage for this, so I am adding here.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -256,16 +256,20 @@ class ResolveSessionCatalog(
case RenameTableStatement(TempViewOrV1Table(oldName), newName, isView) =>
AlterTableRenameCommand(oldName.asTableIdentifier,
newName.asTableIdentifier, isView)
- case DescribeRelation(ResolvedTable(_, ident, _: V1Table), partitionSpec,
isExtended) =>
+ case DescribeRelation(r @ ResolvedTable(_, ident, _: V1Table),
partitionSpec, isExtended)
+ if isSessionCatalog(r.catalog) =>
Review comment:
This change is for `DESCRIBE table`, but adding this check for
consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
