akshatb1 commented on a change in pull request #29870:
URL: https://github.com/apache/spark/pull/29870#discussion_r495586849
##########
File path: core/src/main/scala/org/apache/spark/SparkConf.scala
##########
@@ -568,7 +568,7 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable
with Logging with Seria
// If spark.executor.heartbeatInterval bigger than spark.network.timeout,
// it will almost always cause ExecutorLostFailure. See SPARK-22754.
require(executorTimeoutThresholdMs > executorHeartbeatIntervalMs, "The
value of " +
- s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be no less than
the value of " +
+ s"${networkTimeout}=${executorTimeoutThresholdMs}ms must be greater than
the value of " +
Review comment:
"no less" than is slightly confusing as the application fails if both
values are same, hence changing it to greater. Please let me know if it makes
sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
