shockdm commented on a change in pull request #29496:
URL: https://github.com/apache/spark/pull/29496#discussion_r495896477



##########
File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
##########
@@ -177,4 +188,27 @@ private[k8s] class LoggingPodStatusWatcherImpl(
   private def formatTime(time: String): String = {
     if (time != null ||  time != "") time else "N/A"
   }
+
+  override def watchOrStop(sId: String): Boolean = if (hasCompleted()) {

Review comment:
       With the original comment by @dongjoon-hyun:
   
   > Thank you for making a backporting PR, @jkleckner .
   Could you make a backporting PR to branch-3.0 first?
   To prevent any regression from 2.4 to 3.0, we have a policy for backporting 
sequence. We cannot backport this to branch-2.4 directly.
   
   What would be the correct approach to submit this backport atm?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to