tgravescs opened a new pull request #29906:
URL: https://github.com/apache/spark/pull/29906
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
this PR renames the blacklisting feature. I ended up using
"excludeOnFailure" or "excluded" in most cases but there is a mix. I renamed
the BlacklistTracker to HealthTracker, but for the TaskSetBlacklist
HealthTracker didn't make sense to me since its not the health of the taskset
itself but rather tracking the things its excluded on so I renamed it to be
TaskSetExcludeList. Everything else I tried to use the context and in most
cases excluded made sense. It made more sense to me then blocked since you are
basically excluding those executors and nodes from scheduling tasks on them.
Then can be unexcluded later after timeouts and such. The configs I changed the
name to use excludeOnFailure which I thought explained it.
I unfortunately couldn't get rid of some of them because its part of the
event listener and history files. To keep backwards compatibility I kept the
events and some of the parsing so that the history server would still properly
read older history files. It is not forward compatible though - meaning a new
application write the "Excluded" events so the older history server won't
properly read display them as being blacklisted.
A few of the files below are showing up as deleted and recreated even though
I did a git mv on them. I'm not sure why.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
get rid of problematic language
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Config name changes but the old configs still work but are deprecated.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
updated tests and also manually tested the UI changes and manually tested
the history server reading older versions of history files and vice versa.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
