xkrogen commented on a change in pull request #29906:
URL: https://github.com/apache/spark/pull/29906#discussion_r497595877
##########
File path:
sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java
##########
@@ -291,14 +291,14 @@ public static TServerSocket getServerSSLSocket(String
hiveHost, int portNum, Str
TServerSocket thriftServerSocket =
TSSLTransportFactory.getServerSocket(portNum, 0,
serverAddress.getAddress(), params);
if (thriftServerSocket.getServerSocket() instanceof SSLServerSocket) {
- List<String> sslVersionBlacklistLocal = new ArrayList<String>();
- for (String sslVersion : sslVersionBlacklist) {
-
sslVersionBlacklistLocal.add(sslVersion.trim().toLowerCase(Locale.ROOT));
+ List<String> sslVersionsExcludedLocal = new ArrayList<String>();
+ for (String sslVersion : sslVersionsExcluded) {
+
sslVersionsExcludedLocal.add(sslVersion.trim().toLowerCase(Locale.ROOT));
}
SSLServerSocket sslServerSocket = (SSLServerSocket)
thriftServerSocket.getServerSocket();
List<String> enabledProtocols = new ArrayList<String>();
for (String protocol : sslServerSocket.getEnabledProtocols()) {
- if
(sslVersionBlacklistLocal.contains(protocol.toLowerCase(Locale.ROOT))) {
+ if
(sslVersionsExcludedLocal.contains(protocol.toLowerCase(Locale.ROOT))) {
Review comment:
Best I can tell, it is copied from here:
https://github.com/apache/hive/blob/branch-1.2/service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
