viirya commented on a change in pull request #29916:
URL: https://github.com/apache/spark/pull/29916#discussion_r497765217
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
##########
@@ -135,6 +145,9 @@ public int weigh(File file, ShuffleIndexInformation
indexInfo) {
executors = Maps.newConcurrentMap();
}
this.directoryCleaner = directoryCleaner;
+ if (extraKnownManager != null) {
+ knownManagers.add(extraKnownManager);
+ }
Review comment:
This looks like external shuffle service must support a specified
shuffle manager? Except for built-in shuffle managers in `knownManagers`, are
we sure any arbitrary shuffle manager can be well supported by external shuffle
service?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
