Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5392#discussion_r27928127
--- Diff: core/src/main/scala/org/apache/spark/deploy/Client.scala ---
@@ -79,22 +84,36 @@ private class ClientActor(driverArgs: ClientArguments,
conf: SparkConf)
driverArgs.supervise,
command)
- masterActor ! RequestSubmitDriver(driverDescription)
+
masterEndpoint.sendWithReply[SubmitDriverResponse](RequestSubmitDriver(driverDescription)).
+ onComplete {
+ case Success(v) => self.send(v)
+ case Failure(e) =>
+ println(s"Error sending messages to master
${driverArgs.master}, exiting.")
+ e.printStackTrace()
+ System.exit(-1)
+ }
case "kill" =>
val driverId = driverArgs.driverId
- masterActor ! RequestKillDriver(driverId)
+
masterEndpoint.sendWithReply[KillDriverResponse](RequestKillDriver(driverId)).onComplete
{
+ case Success(v) => self.send(v)
--- End diff --
Seems like you could have a helper method to do this error checking instead
of copying the code in several places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
