Ngone51 commented on a change in pull request #29916:
URL: https://github.com/apache/spark/pull/29916#discussion_r498317739
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
##########
@@ -135,6 +145,9 @@ public int weigh(File file, ShuffleIndexInformation
indexInfo) {
executors = Maps.newConcurrentMap();
}
this.directoryCleaner = directoryCleaner;
+ if (extraKnownManager != null) {
+ knownManagers.add(extraKnownManager);
+ }
Review comment:
> Yes, if user sets their own shuffle manager (spark.shuffle.manager),
they need to be aware that their shuffle manager needs to work or co-exist with
external shuffle service.
It's only required when users enable external shuffle service, right?
This change looks likes any shuffle manager will be added to
`knownManagers`. If so, do we still need `knownManagers`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
