Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5307#discussion_r27930690
  
    --- Diff: 
core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala ---
    @@ -123,12 +130,34 @@ private[spark] class DiskBlockObjectWriter(
        */
       private var numRecordsWritten = 0
     
    +  private var sparkConf:SparkConf = null
    +
       override def open(): BlockObjectWriter = {
         if (hasBeenClosed) {
           throw new IllegalStateException("Writer already closed. Cannot be 
reopened.")
         }
         fos = new FileOutputStream(file, true)
    -    ts = new TimeTrackingOutputStream(fos)
    +    var isEncryptedShuffle: Boolean = if (sparkConf != null) {
    +      sparkConf.getBoolean("spark.encrypted.shuffle", false)
    +    }
    +    else {
    +      false
    +    }
    +    if (isEncryptedShuffle) {
    --- End diff --
    
    In fact you could even inline the `conf.getBoolean` call here.
    
    (BTW you have this code repeated later in the file, same comments apply 
there.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to